Skip to content

fix(button-group): fix button group colors in selected state#17267

Open
didimmova wants to merge 2 commits intomasterfrom
didimmova/fix-button-group-colors
Open

fix(button-group): fix button group colors in selected state#17267
didimmova wants to merge 2 commits intomasterfrom
didimmova/fix-button-group-colors

Conversation

@didimmova
Copy link
Copy Markdown
Contributor

Closes #17221

test with this theming pr - IgniteUI/igniteui-theming#571

Type of Change (check all that apply):

  • Bug fix
  • New functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes)
  • Documentation
  • Demos
  • CI/CD
  • Tests
  • Changelog
  • Skills/Agents

Component(s) / Area(s) Affected:

How Has This Been Tested?

  • Unit tests
  • Manual testing
  • Automated e2e tests

Test Configuration:

  • Angular version:
  • Browser(s):
  • OS:

Screenshots / Recordings

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them
  • Accessibility (ARIA, keyboard navigation, focus management) has been verified

@didimmova didimmova requested a review from adrianptrv May 8, 2026 07:44
Copilot AI review requested due to automatic review settings May 8, 2026 07:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes incorrect border coloring for selected igx-button-group items in the focused/hovered focused states, aligning the selected-state visuals with the intended theme tokens (per the linked theming PR and issue).

Changes:

  • Use item-selected-border-color (instead of item-selected-hover-border-color) for the selected + focused state border.
  • Use item-selected-hover-border-color for the selected + focused + hovered state border (instead of item-selected-border-color).
  • Remove now-redundant Indigo-only border-color overrides that matched the new generalized behavior.

@didimmova didimmova linked an issue May 8, 2026 that may be closed by this pull request
@adrianptrv adrianptrv added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

button-group ✨ themes ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Button Group border should be transparent in Bootstrap

3 participants