Allow broadcasting of more integer ops #15
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonOresten
force-pushed
the
arithmetic-ops
branch
from
23d2ae9 to
f719438
Compare
Contributor
Author
|
This should probably be a tracker issue. |
AntonOresten
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
min,max.mod1overlay.There are other operators like
fld1,fldmod1that currently fail. It seemsBase.fld1is equivalent toBase.cld, but marks a slightly different intent, and pairs well withmod1. I'm also not sure whatmodfalls back to, so the currentmod1implementation might not be as efficient as it could be. It differs from the Base method in that it uses?for the conditional, becauseifelsefails.