Surround the GIL with a ReentrantLock on the Julia side.#637
Open
mkitti wants to merge 7 commits intoJuliaPy:mainfrom
Open
Surround the GIL with a ReentrantLock on the Julia side.#637mkitti wants to merge 7 commits intoJuliaPy:mainfrom
mkitti wants to merge 7 commits intoJuliaPy:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python GIL should only be able obtained by a single Julia thread / task.
To enforce this, we use a ReentrantLock on the Julia side that must be obtained
before trying to acquire the Python GIL.
Implements the fix suggested by #627 by @NHDaly and @kpamnany
Also inspired by https://stackoverflow.com/questions/47167251/pygilstate-ensure-causing-deadlock/49202868#49202868