Fix fm-shim-backend D-Bus name registration and quoting#357
Open
assisted-by-ai wants to merge 1 commit intoKicksecure:masterfrom
Open
Fix fm-shim-backend D-Bus name registration and quoting#357assisted-by-ai wants to merge 1 commit intoKicksecure:masterfrom
assisted-by-ai wants to merge 1 commit intoKicksecure:masterfrom
Conversation
…otify - Quote pkg-config output in build script via bash arrays to prevent injection through malicious .pc files - Add NotifyAccess=main to systemd service to restrict sd_notify to the main process only - Add DBUS_NAME_FLAG_DO_NOT_QUEUE to fail fast when another process owns the D-Bus name, replacing the IN_QUEUE warning with an EXISTS error exit https://claude.ai/code/session_01HJPNe7hjMrPvPtuJmPBhNa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the robustness and security of the fm-shim-backend D-Bus service by fixing shell argument quoting issues in the build script and preventing the service from running in a degraded state when another process owns the D-Bus name.
Key Changes
pkg-configoutput in arrays and properly expanding them with"${array[@]}"syntax instead of unquoted command substitutionDBUS_NAME_FLAG_DO_NOT_QUEUEflag to prevent the service from being queued when the D-Bus name is unavailableNotifyAccess=mainto the service unit to properly handle systemd readiness notificationsImplementation Details
The changes ensure that:
https://claude.ai/code/session_01HJPNe7hjMrPvPtuJmPBhNa