refactor: make evaluator cast dispatch static#318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Evaluator casts were still selected through runtime type matching, which added avoidable overhead and kept a lot of cast-related logic and tests concentrated in dispatcher-style code.
There were also several no-op cast paths that still flowed through binding/execution even when the source and target types were already identical, plus the projection executor was still rebuilding its temporary arena values buffer for each row.
Issue link:
What is changed and how it works?
eval_castas the only cast execution entrypoint.Cow<LogicalType>through the relevant evaluator factory / type-combination paths to reduce unnecessary cloning where the type only needs to be borrowed.binary.rs,unary.rs, andcast.rsfiles while keeping per-type implementations in the existing flat evaluator files.Code changes
Check List
Tests
Side effects
Note for reviewer
The main review surface is:
Validation used for this branch:
cargo test -q