Remove colored_json::enable_ansi_support() calls#1652
Merged
jtran merged 2 commits intoMay 24, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dependabot/cargo/colored_json-5.0.0 #1652 +/- ##
=======================================================================
- Coverage 64.03% 63.89% -0.15%
=======================================================================
Files 44 44
Lines 8121 8117 -4
=======================================================================
- Hits 5200 5186 -14
- Misses 2921 2931 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jtran
approved these changes
May 24, 2026
Contributor
|
Stacked on #1598. |
jessfraz
pushed a commit
that referenced
this pull request
May 24, 2026
* Bump colored_json from 4.1.0 to 5.0.0 Bumps [colored_json](https://github.com/ctron/colored_json) from 4.1.0 to 5.0.0. - [Release notes](https://github.com/ctron/colored_json/releases) - [Commits](ctron/colored_json@v4.1.0...v5.0.0) --- updated-dependencies: - dependency-name: colored_json dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Remove colored_json::enable_ansi_support() calls (#1652) * Remove colored_json::enable_ansi_support() call from iostreams.rs * Remove newline --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Jonathan Tran <jonnytran@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Jonathan Tran <jonnytran@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the migration away from
colored_json's ANSI support bootstrapping on Windows. Thecolored_json::enable_ansi_support()call was redundant alongsidenu_ansi_term::enable_ansi_support(), which already handles Windows ANSI terminal initialization.Changes
src/iostreams.rs: Removed#[cfg(windows)]call tocolored_json::enable_ansi_support()and its associated comment. Thenu_ansi_term::enable_ansi_support()call remains to preserve Windows ANSI color support.