Skip to content

Make more proprietary formats available for import#1198

Merged
alteous merged 2 commits into
mainfrom
alteous/proprietary-formats
May 22, 2026
Merged

Make more proprietary formats available for import#1198
alteous merged 2 commits into
mainfrom
alteous/proprietary-formats

Conversation

@alteous
Copy link
Copy Markdown
Contributor

@alteous alteous commented May 15, 2026

No description provided.

@alteous alteous mentioned this pull request May 15, 2026
Copy link
Copy Markdown
Contributor

@maxammann maxammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust wise looks goos

@alteous
Copy link
Copy Markdown
Contributor Author

alteous commented May 15, 2026

The tests are failing due to a problem with the pyo3-stub-gen parser. I've prepared a patch for them: Jij-Inc/pyo3-stub-gen#465

@alteous alteous changed the title Make more propietary formats available for import Make more proprietary formats available for import May 15, 2026
@alteous alteous force-pushed the alteous/proprietary-formats branch from 2ce5195 to 6321cd7 Compare May 19, 2026 13:19
@alteous alteous force-pushed the alteous/proprietary-formats branch from 6321cd7 to 1cd810a Compare May 22, 2026 11:01
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

❌ Patch coverage is 22.22222% with 21 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@72bcdfd). Learn more about missing BASE report.

Files with missing lines Patch % Lines
modeling-cmds/src/format/mod.rs 22.22% 21 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1198   +/-   ##
=======================================
  Coverage        ?   29.71%           
=======================================
  Files           ?       34           
  Lines           ?     1656           
  Branches        ?        0           
=======================================
  Hits            ?      492           
  Misses          ?     1164           
  Partials        ?        0           
Flag Coverage Δ
unittests 29.71% <22.22%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alteous alteous merged commit 3090e0e into main May 22, 2026
11 checks passed
@alteous alteous deleted the alteous/proprietary-formats branch May 22, 2026 12:19
alteous added a commit that referenced this pull request May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants