feat: mapco-10524 & MAPCO-10792#40
Merged
Merged
Conversation
- Replace sync.layers array with sync.layerQueries map - Layer list derived from layerQueries keys - buildLayerQuery reads per-layer query; throws on missing so layer skips - Store raw geography in properties jsonb alongside geom column - Add LAYER_QUERIES env override; update tests
RonIsraeli123
force-pushed
the
feature/MAPCO-10524_10
branch
from
23ee345 to
f7ed904
Compare
asafmas-rnd
requested changes
Jun 9, 2026
Replace sync.layerQueries (Record<string, string>) with sync.layers (LayerConfig[]), where each entry pairs a layer name with its GraphQL query. - Add LayerConfig type in its own file (src/types/layerConfig.ts) - buildLayerQuery looks up the query by layer name in the array - Derive layer names via config.layers.map(l => l.name) - Map env var LAYERS (json) to sync.layers - Drop redundant geography blob from stored properties - Update default config, helm values/example, and tests
insertObjects used orIgnore (ON CONFLICT DO NOTHING), so updated source objects with an existing (layer_name, id) were silently dropped and the stale row kept. Switch both the batch and per-row paths to orUpdate so geom and properties are refreshed on conflict; keys and created_at stay.
Add tests asserting insertObjects upserts via orUpdate on the (layer_name, id) conflict, skips on empty input, and falls back to per-object upserts (logging and continuing) when a batch or individual insert throws.
added 2 commits
June 9, 2026 17:55
…rver into feature/MAPCO-10524_10
|
🎫 Related Jira Issue: MAPCO-10792 |
asafmas-rnd
requested changes
Jun 9, 2026
asafmas-rnd
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: #XXX , #XXX ...
Closes #XXX ...
Further information: