refactor(transaction-controller): encapsulate provider logic#8273
Open
matthewwalsh0 wants to merge 11 commits intomainfrom
Open
refactor(transaction-controller): encapsulate provider logic#8273matthewwalsh0 wants to merge 11 commits intomainfrom
matthewwalsh0 wants to merge 11 commits intomainfrom
Conversation
matthewwalsh0
force-pushed
the
feat/encapsulate-provider-util
branch
2 times, most recently
from
c2ffb95 to
72ca7a5
Compare
…ethQuery from transaction-controller Replace all ethQuery/EthQuery usage with a new rpcRequest() utility that accepts messenger + chainId/networkClientId + method + params. Any file can now send RPC requests without passing around ethQuery instances. - Add utils/provider.ts with rpcRequest() and getProvider() functions - Migrate all utils, gas-flows, helpers, hooks, and TransactionController - Update GasFeeFlowRequest type: ethQuery -> networkClientId (BREAKING) - Update determineTransactionType signature to options object (BREAKING) - Remove @metamask/eth-query dependency - Update all test files to match new signatures
matthewwalsh0
force-pushed
the
feat/encapsulate-provider-util
branch
from
72ca7a5 to
a7e5332
Compare
…nts for connectivity-controller
matthewwalsh0
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
packages/transaction-controller/src/helpers/PendingTransactionTracker.ts
Outdated
Show resolved
Hide resolved
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
packages/transaction-controller/src/TransactionControllerIntegration.test.ts
Show resolved
Hide resolved
| const networkClientId = | ||
| transactionNetworkClientId ?? | ||
| (this.#findNetworkClientIdByChainId(chainId) as string); | ||
| getNetworkClientId({ messenger: this.#messenger, chainId }); |
There was a problem hiding this comment.
GasFeePoller network lookup failure aborts all transaction updates
Low Severity
In #getGasFeeControllerDataByChainId, getNetworkClientId throws for unrecognized chain IDs. Since this runs inside a for loop building a map for ALL chains, a single unknown chain aborts gas fee data fetching for every chain. The old callback could return undefined silently, allowing partial success. This means one stale transaction with an unknown chain could block gas fee polling for all other valid transactions in that cycle.
Member
Author
|
@metamaskbot publish-preview |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Currently,
transaction-controllerpassesethQueryinstances throughout the codebase — into utils, helpers, hooks, and gas flows — to make RPC calls. This couples every layer toEthQueryinternals and makes the provider plumbing verbose and fragile.This PR introduces a
utils/provider.tsmodule with functions includingrpcRequestandgetProvider, meaning allEthQueryusage is replaced, and all provider logic is encapsulated and callable anywhere with amessenger.References
Checklist
Note
Medium Risk
Refactors transaction publishing/gas estimation/pending tracking to replace
EthQuerywith messenger-drivenrpcRequest, which could subtly change RPC call shapes/ordering and networkClientId resolution across many paths.Overview
Removes
@metamask/eth-queryand threads provider access through a newutils/provider.tsAPI (getProvider,rpcRequest,getNetworkClientId,getChainId) so helpers/flows no longer receive or constructEthQueryinstances.Transaction submission, gas estimation/fee flows (including Linea), balance/simulation utilities, batch publishing hooks, and pending transaction tracking are updated to use
rpcRequest+networkClientId/chainIdresolution viaNetworkControllermessenger actions, and internal helper signatures are adjusted accordingly (e.g.,PendingTransactionTrackernow takesnetworkClientIddirectly).Tests are updated to mock
rpcRequest/provider utilities, account for changed network client ID lookup, and align integration mocks with the updated RPC call sequence;determineTransactionTypeis no longer exported from the package and the changelog marks this as a breaking removal.Written by Cursor Bugbot for commit a0caca0. This will update automatically on new commits. Configure here.