feat: use @metamask/messenger/generate-action-types CLI#3914
Draft
cryptodev-2s wants to merge 1 commit intocontroller-refactorsfrom
Draft
feat: use @metamask/messenger/generate-action-types CLI#3914cryptodev-2s wants to merge 1 commit intocontroller-refactorsfrom
cryptodev-2s wants to merge 1 commit intocontroller-refactorsfrom
Conversation
Replace local copy-pasted script with the CLI from @metamask/messenger. Uses preview build via resolution until release.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## controller-refactors #3914 +/- ##
=======================================================
Coverage ? 98.55%
=======================================================
Files ? 425
Lines ? 12343
Branches ? 1935
=======================================================
Hits ? 12165
Misses ? 178
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Replace the local copy-pasted
scripts/generate-method-action-types.mts(781 lines) with the CLI from@metamask/messenger/generate-action-types.Currently uses a preview build (
@metamask-previews/messenger@0.3.0-preview-a462582) via resolution. Once MetaMask/core#8264 is merged and released, the resolution should be removed and the dependency updated to the released version.References
generate-action-typesCLI tool as subpath export core#8264