Skip to content

[26.2] fixed shearing sulfur cubes with custom shears#10826

Open
cech12 wants to merge 1 commit into
MinecraftForge:26.2from
cech12:feature/sulfur-cube-shearing
Open

[26.2] fixed shearing sulfur cubes with custom shears#10826
cech12 wants to merge 1 commit into
MinecraftForge:26.2from
cech12:feature/sulfur-cube-shearing

Conversation

@cech12

@cech12 cech12 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

This PR fixes shearing sulfur cubes with custom shears. Interacting with sulfur cubes containing a block didn't result in shearing off the block as vanilla shears.

I reused the tool action SHEARS_HARVEST, because I don't think an extra tool action for handling sulfur cube shearing is necessary.

I also added a corresponding automated test.

@autoforge autoforge Bot added Triage This request requires the active attention of the Triage Team. Requires labelling or reviews. LTS This issue/PR is related to the current LTS version. labels Jun 19, 2026
@autoforge autoforge Bot requested a review from a team June 19, 2026 22:32
@LexManos

Copy link
Copy Markdown
Member

Overall looks good/simple enough.
Only thing I can think of is needing to adapt things to properly override the IForgeShearable.onSheared function
When I get back to a computer i'll run the test/pull. Unless someone runs the test before me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LTS This issue/PR is related to the current LTS version. Triage This request requires the active attention of the Triage Team. Requires labelling or reviews.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants