fix(sbom): release lock before sleeping in _rate_limit#1896
Open
mesutoezdil wants to merge 1 commit into
Open
Conversation
time.sleep was called inside the _rate_lock block, blocking all threads from checking their own domain rate limit while one thread slept. With _MAX_WORKERS=12 querying crates.io, npm, and pypi concurrently, this made the thread pool effectively serial. Move the sleep outside the lock so threads for different domains can proceed concurrently.
mesutoezdil
requested review from
a team,
derekwaynecarr and
mrunalp
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_rate_limitcalledtime.sleep(wait)inside the_rate_lockblock.While 1 thread slept (0.15s per call), all other threads blocked on the lock, even when querying different domains.
With
_MAX_WORKERS = 12running crates.io, npm, and pypi concurrently, the thread pool was effectively serial.Move
time.sleep(wait)outside the lock.Update
_last_request[domain]before sleeping so subsequent threads see the correct timestamp.Measured concurrent calls to 2 independent domains before and after: