Add a test for <nv/target> to validate old dialect support. #7241
+73
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davebayer
reviewed
Jan 15, 2026
Comment on lines
+23
to
+56
| add_library( | ||
| "nvtarget_cpp${dialect}" | ||
| OBJECT | ||
| nvtargettest.cpp | ||
| ) | ||
| add_library( | ||
| "nvtarget_cuda${dialect}" | ||
| OBJECT | ||
| nvtargettest.cu | ||
| ) | ||
|
|
||
| target_include_directories( | ||
| "nvtarget_cpp${dialect}" | ||
| PRIVATE "${libcudacxx_SOURCE_DIR}/include" | ||
| ) | ||
| target_include_directories( | ||
| "nvtarget_cuda${dialect}" | ||
| PRIVATE "${libcudacxx_SOURCE_DIR}/include" | ||
| ) | ||
|
|
||
| set_target_properties( | ||
| "nvtarget_cpp${dialect}" | ||
| PROPERTIES | ||
| COMPILE_OPTIONS "${headertest_warning_levels_host}" | ||
| CXX_STANDARD "${dialect}" | ||
| CXX_STANDARD_REQUIRED ON | ||
| ) | ||
| set_target_properties( | ||
| "nvtarget_cuda${dialect}" | ||
| PROPERTIES | ||
| COMPILE_OPTIONS "${headertest_warning_levels_device}" | ||
| CUDA_STANDARD "${dialect}" | ||
| CUDA_STANDARD_REQUIRED ON | ||
| ) |
Contributor
There was a problem hiding this comment.
Wouldn't this be a better solution:
if ("cxx_std_${dialect}" IN_LIST CMAKE_CXX_COMPILE_FEATURES)
add_library("nvtarget_cpp${dialect}" OBJECT nvtargettest.cpp)
target_compile_features("nvtarget_cpp${dialect}" PRIVATE "cxx_std_${dialect}")
endif()
if ("cuda_std_${dialect}" IN_LIST CMAKE_CUDA_COMPILE_FEATURES)
add_library("nvtarget_cuda${dialect}" OBJECT nvtargettest.cu)
target_compile_features("nvtarget_cuda${dialect}" PRIVATE "cuda_std_${dialect}")
endif()It will check whether the compiler even supports the dialect first
Member
Author
There was a problem hiding this comment.
Yeah, I'll swap it out for that, I'm operating off the assumption that we don't have to deal with incompatible compilers by now.
Contributor
😬 CI Workflow Results🟥 Finished in 5h 54m: Pass: 99%/250 | Total: 6d 01h | Max: 5h 53m | Hits: 84%/346083See results here. |
miscco
reviewed
Jan 15, 2026
Comment on lines
+3
to
+18
| if (MSVC) | ||
| set( | ||
| nvtarget_dialects | ||
| 14 | ||
| 17 | ||
| 20 | ||
| ) | ||
| else() | ||
| set( | ||
| nvtarget_dialects | ||
| 11 | ||
| 14 | ||
| 17 | ||
| 20 | ||
| ) | ||
| endif() |
Contributor
There was a problem hiding this comment.
I believe we want to run this in all configurations and C++20 is only available in some, so we should make sure this is supported
Contributor
There was a problem hiding this comment.
This would be solved by checking the available compiler features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #7196
Checklist