Clarify parallel scheduler build#2104
Open
vasama wants to merge 4 commits into
Open
Conversation
ericniebler
approved these changes
May 28, 2026
Collaborator
|
/ok to test 8cdf70e |
Contributor
Author
|
I see there are many build failures, but they don't look directly related to my changes. Perhaps applying the header only configuration is what is breaking the CI builds? 🤔 |
* Configure STDEXEC_PARALLEL_SCHEDULER_HEADER_ONLY appropriately based on STDEXEC_BUILD_PARALLEL_SCHEDULER. * If STDEXEC_BUILD_PARALLEL_SCHEDULER is off, define the parallel_scheduler target as an empty interface target. Create the STDEXEC::parallel_scheduler alias target unconditionally. * Build example.sudoku regardless of configuration. * Build tests using the user-defined stdexec namespace. * Remove local header-only macro override in parallel scheduler test. * Remove unneeded weak attribute from default parallel scheduler definition. The status quo with the weak attribute simply means that in the case of a missing definition, instead of producing an error, the linker ignores the symbol and creates a null reference. This ultimately results in a runtime segmentation fault when the parallel scheduler backend is queried.
vasama
force-pushed
the
build-parallel-scheduler
branch
from
8cdf70e to
db9705d
Compare
Contributor
Author
|
I pushed some fixes. The MSVC and GCC-13 issues I was able to test locally. For the MacOS issue, missing support for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configure
STDEXEC_PARALLEL_SCHEDULER_HEADER_ONLYappropriately based onSTDEXEC_BUILD_PARALLEL_SCHEDULER.If
STDEXEC_BUILD_PARALLEL_SCHEDULERis off, define theparallel_schedulertarget as an empty interface target.Create the
STDEXEC::parallel_scheduleralias target unconditionally.Build
example.sudokuregardless of configuration.Build tests using the user-defined stdexec namespace.
Remove local header-only macro override in parallel scheduler test.
Remove unneeded weak attribute from default parallel scheduler definition.
The status quo with the weak attribute simply means that in the case of a missing definition, instead of producing an error, the linker ignores the symbol and creates a null reference. This ultimately results in a runtime segmentation fault when the parallel scheduler backend is queried.