[spalenque] - #14274 * fix slug in component categories creation

Author: santipalenque

software/code/infrastructure/active_records/OpenStackComponentCategory.php

@@ -46,24 +46,22 @@ protected function onBeforeWrite()
             $this->Order = $siblings_count + 1;
         }
 
-        $slug = strtolower($this->Name);
-        $slug = preg_replace("/[^a-z0-9_\s-]/", "", $slug);
-        $slug = preg_replace("/[\s-]+/", " ", $slug);
-        $slug = preg_replace("/[\s_]/", "-", $slug);
-
-        $checkSlug = $slug;
-        $counter = 0;
-        while($slugExists = OpenStackComponentCategory::get()->filter('Slug', $checkSlug)->count()) {
-            $counter++;
-            $checkSlug = $slug . '-' . $counter;
-        }
+        if (empty($this->Slug)) {
+            $slug = strtolower($this->Name);
+            $slug = preg_replace("/[^a-z0-9_\s-]/", "", $slug);
+            $slug = preg_replace("/[\s-]+/", " ", $slug);
+            $slug = preg_replace("/[\s_]/", "-", $slug);
+
+            $checkSlug = $slug;
+            $counter = 0;
+            while ($slugExists = OpenStackComponentCategory::get()->exclude('ID', $this->ID)->filter('Slug', $checkSlug)->count()) {
+                $counter++;
+                $checkSlug = $slug . '-' . $counter;
+            }
 
-        if($checkSlug) {
-            $slug = $checkSlug;
+            $this->Slug = $checkSlug;
         }
 
-        $this->Slug = $slug;
-
         // if removed from a collection of subcategories we disable the category
         if (!$this->ParentCategoryID && $this->isChanged('ParentCategoryID')) {
             $this->Enabled = 0;