Feat | API OAuth2UserApiController routes v1#106
Open
matiasperrone-exo wants to merge 3 commits intomainfrom
Open
Feat | API OAuth2UserApiController routes v1#106matiasperrone-exo wants to merge 3 commits intomainfrom
matiasperrone-exo wants to merge 3 commits intomainfrom
Conversation
matiasperrone-exo
added
the
documentation
matiasperrone-exo
force-pushed
the
feat/openapi----api-v1---oauth2userapicontroller
branch
from
e5e28a9 to
54025c8
Compare
smarcet
force-pushed
the
main
branch
2 times, most recently
from
ae79f5e to
4b5b726
Compare
matiasperrone-exo
force-pushed
the
feat/openapi----api-v1---oauth2userapicontroller
branch
10 times, most recently
from
28e31ae to
2c37852
Compare
martinquiroga-exo
approved these changes
Feb 18, 2026
martinquiroga-exo
left a comment
martinquiroga-exo
left a comment
There was a problem hiding this comment.
LGTM
@matiasperrone-exo please add the clickup card link to this PR please
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughAdds extensive OpenAPI annotations and multiple REST endpoints to the OAuth2 user controller; adds Swagger schema classes for UserInfo, pagination, request payloads, and updates the OAuth2 security schema. Changes
Sequence Diagram(s)sequenceDiagram
participant Client as Client
participant Controller as OAuth2UserApiController
participant Auth as OAuth2 Security
participant Service as UserService
participant DB as Database/Storage
Client->>Auth: obtain access token
Client->>Controller: HTTP request (e.g., POST /api/v1/users) with token
Controller->>Auth: validate token & scopes
Auth-->>Controller: token validated
Controller->>Service: invoke create/update/get/updateGroups/updatePic
Service->>DB: read/write user record / groups / store pic
DB-->>Service: operation result
Service-->>Controller: domain/result object
Controller-->>Client: JSON response (200/201/4xx/5xx)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
|
📘 OpenAPI / Swagger preview ➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-106/ This page is automatically updated on each push to this PR. |
smarcet
reviewed
Mar 14, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/Http/Controllers/Api/OAuth2/OAuth2UserApiController.php`:
- Around line 499-504: The OpenAPI response for the update operation in
OAuth2UserApiController currently uses HttpResponse::HTTP_CREATED (201); change
it to HttpResponse::HTTP_OK (200) so the OA\Response for the update (the block
creating new OA\Response in OAuth2UserApiController, around the
profile-picture/update endpoint) correctly reflects an update operation
returning 200 instead of 201.
- Around line 801-805: The OpenAPI annotation in OAuth2UserApiController
currently documents an update operation with response:
HttpResponse::HTTP_CREATED (201); change that OA\Response to use
HttpResponse::HTTP_OK (200) or HttpResponse::HTTP_NO_CONTENT (204) instead and
update the controller method that performs the user group assignment (the method
containing this OA\Response) so the actual HTTP response status it returns
matches the new code.
- Around line 397-402: The OpenAPI annotation in OAuth2UserApiController is
incorrectly using HttpResponse::HTTP_CREATED for a PUT update response; update
the OA\Response entry in the controller's update annotation to use
HttpResponse::HTTP_OK (200) so the documented status matches the update
semantics and returned User payload in the OA\JsonContent.
- Around line 450-455: The OpenAPI response annotation in
OAuth2UserApiController uses HttpResponse::HTTP_CREATED for an update endpoint;
change the response status to HttpResponse::HTTP_OK (200) to match an update
operation. Locate the OA\Response entry in the controller annotation (the block
that currently has response: HttpResponse::HTTP_CREATED and description
'Updated') and replace HttpResponse::HTTP_CREATED with HttpResponse::HTTP_OK
and, if desired, update the description to 'OK' or keep 'Updated' for clarity.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d9a428ab-13a3-4653-a1b3-9b59842b0f6b
📒 Files selected for processing (9)
app/Http/Controllers/Api/OAuth2/OAuth2UserApiController.phpapp/Swagger/Models/UserInfoResponseSchema.phpapp/Swagger/OAuth2UserApiControllerSchemas.phpapp/Swagger/Requests/CreateUserRequestSchema.phpapp/Swagger/Requests/UpdateUserGroupsRequestSchema.phpapp/Swagger/Requests/UpdateUserPicRequestSchema.phpapp/Swagger/Requests/UpdateUserRequestSchema.phpapp/Swagger/Requests/UserFieldsSchema.phpapp/Swagger/Security/UsersOAuth2Schema.php
smarcet
reviewed
Mar 14, 2026
smarcet
reviewed
Mar 14, 2026
smarcet
requested changes
Mar 14, 2026
Collaborator
smarcet
left a comment
smarcet
left a comment
There was a problem hiding this comment.
@matiasperrone-exo please review comments and rebase with main to get the proper preview for the swagger doc many thanks
smarcet
reviewed
Mar 14, 2026
smarcet
reviewed
Mar 14, 2026
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/Swagger/Security/UsersOAuth2Schema.php`:
- Line 3: The namespace declaration in UsersOAuth2Schema.php is incorrect
(currently App\Swagger\schemas) and breaks PSR-4 autoloading; update the
namespace to match the file path (use App\Swagger\Security) so the class
UsersOAuth2Schema is declared under the App\Swagger\Security namespace, then run
a quick Composer dump-autoload to verify resolution.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d9f0529e-eb78-4a4f-87f4-70c27e0a825a
📒 Files selected for processing (3)
app/Http/Controllers/Api/OAuth2/OAuth2UserApiController.phpapp/Swagger/OAuth2UserApiControllerSchemas.phpapp/Swagger/Security/UsersOAuth2Schema.php
🚧 Files skipped from review as they are similar to previous changes (1)
- app/Swagger/OAuth2UserApiControllerSchemas.php
matiasperrone-exo
force-pushed
the
feat/openapi----api-v1---oauth2userapicontroller
branch
from
174fd81 to
d08d047
Compare
|
📘 OpenAPI / Swagger preview ➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-106/ This page is automatically updated on each push to this PR. |
matiasperrone-exo
force-pushed
the
feat/openapi----api-v1---oauth2userapicontroller
branch
from
d08d047 to
b545fb6
Compare
Contributor
Author
|
@smarcet the branch was rebased |
|
📘 OpenAPI / Swagger preview ➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-106/ This page is automatically updated on each push to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task:
Ref: https://app.clickup.com/t/86b8e6k87
Endpoints:
Summary by CodeRabbit