feat: Update type icons to include logo (ref: sprites/pull/199)#1443
feat: Update type icons to include logo (ref: sprites/pull/199)#1443Naramsim merged 3 commits intoPokeAPI:masterfrom
Conversation
data/v2/build.py
Outdated
| f"types/{generation}/{game}/{info[0]}.png" | ||
| ) | ||
| ), | ||
| "logo": file_path_or_none( |
There was a problem hiding this comment.
Is it better logo , small or symbol_icon? On bulbapedia there's the term symbol icon
There was a problem hiding this comment.
lets go with symbol_icon? matching bulbapedia is cool
There was a problem hiding this comment.
ok, I also think that matching is better
Naramsim
left a comment
Naramsim
left a comment
There was a problem hiding this comment.
Which naming convention is better?
|
hi @FallenDeity can you run |
|
A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data. |
|
The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data. |
4 participants
Adds a new field
logofor type icons which references the small icons added in PokeAPI/sprites#199