Skip to content

Fix NPM vulnerabilites #5459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andyleejordan merged 1 commit into from
Apr 8, 2026
+13 −26
Merged

Fix NPM vulnerabilites #5459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@
- After updating, verify: `npm run compile` (build), `npm run lint` (lint), `npm audit` (security)
- The ESLint packages (`eslint`, `@eslint/js`, `typescript-eslint`, `eslint-config-prettier`) should be updated together
- Fix any new lint warnings from updates to ESLint
- Use `npm audit` to identify vulnerabilities
- Do not use `npm audit fix --force` when a vulnerability is in a transitive dependency, instead add an `overrides` entry
33 changes: 7 additions & 26 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@
"typescript": "^6.0.2",
"typescript-eslint": "^8.58.0"
},
"overrides": {
"serialize-javascript": "^7.0.5",
"diff": "^8.0.3"
},
Comment on lines +97 to +100
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new global overrides force diff to ^8.0.3 and serialize-javascript to ^7.0.5, but mocha@11.7.5 in the lockfile declares dependencies on diff ^7.0.0 and serialize-javascript ^6.0.2 (see package-lock.json:4687-4699). This bypasses upstream semver constraints and risks runtime/test failures if Mocha isn’t compatible with the new major versions. Prefer upgrading the dependency that brings in Mocha (or Mocha itself) to a version that officially depends on these secure versions; if that’s not possible, consider an override strategy that stays within Mocha’s supported major ranges and only bumps to a patched release.

Suggested change
"overrides": {
"serialize-javascript": "^7.0.5",
"diff": "^8.0.3"
},

Copilot uses AI. Check for mistakes.
"extensionDependencies": [
"vscode.powershell"
],
Expand Down
Loading