Adding check for empty string as well as null#102
Open
reubenmiller wants to merge 3 commits into
Open
Conversation
Author
|
Resolves $null credential issue referenced at the end of #94 |
Signed-off-by: Gilbert Sanchez <me@gilbertsanchez.com>
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent an erroneous warning when Invoke-PSDepend is called with -Credentials but a given dependency does not specify a credential name (or the name becomes an empty string due to [string] casting).
Changes:
- Updates
Resolve-Credentialto treat empty string credential names the same as$null(via[string]::IsNullOrEmpty()), preventing spurious warnings. - Modifies a brace near the end of
Parse-Dependency(currently resulting in unbalanced braces / incorrect scoping in the updated file).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
394
to
398
|
|
||
| $credential = $null | ||
| if (($null -ne $Name) -and ($null -ne $Credentials)) { | ||
| if (![string]::IsNullOrEmpty($Name) -and ($null -ne $Credentials)) { | ||
|
|
||
| if ($Credentials.ContainsKey($Name)) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the -Credentials parameter when calling
Invoke-PSDependfor dependencies that don't require credentials, would result in the erroneous warningWARNING: No credential found for the specified name . Was the dependency misconfigured?Example
File
depends.psd1@{ "PSModule1" = @{ "Name" = "PSModule1" "Version" = "1.0.0" "DependencyType" = "PSGalleryModule" "Credential" = "repo1WithCredential" "Parameters" = @{ "Repository" = "repo1WithCredential" } } "PSModule2" = @{ "Name" = "PSModule2" "Version" = "2.1.0" "DependencyType" = "PSGalleryModule" "Parameters" = @{ "Repository" = "repo2WithoutCredential" }Would generate the warning when processing the
PSModule2dependency.Fix
The -Name parameter in
Resolve-Credentialis cast from $null to an empty string "". So now both null and an empty string are checked.