feat(qwik-city): add getOrigin option to QwikCityBunOptions and QwikC… #8251
+88
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: eb46df2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ityDenoOptions for improved URL handling
JerryWu1234
force-pushed
the
fix_original
branch
from
a66e5a5 to
91f4f25
Compare
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
wmertens
requested changes
Jan 19, 2026
Member
wmertens
left a comment
wmertens
left a comment
There was a problem hiding this comment.
good but needs a little bit more
|
|
||
| function getRequestUrl(request: Request, opts: QwikCityBunOptions) { | ||
| const url = new URL(request.url); | ||
| const origin = opts.getOrigin?.(request) ?? opts.origin ?? Bun.env.ORIGIN ?? url.origin; |
Member
There was a problem hiding this comment.
Also, remove the ?? url.origin from the end so that it becomes undefined if not provided.
Then, if it is undefined, just return the original url, otherwise create the new URL.
…Options and QwikCityDenoOptions, update URL handling logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ityDenoOptions for improved URL handling
What is it?
Description
fix #8250
feat(qwik-city): add getOrigin option to QwikCityBunOptions and QwikCityDenoOptions for improved URL handling
Checklist
pnpm change