fix: Fix navigation between toolbox and flyout in all layouts#9681
Open
fix: Fix navigation between toolbox and flyout in all layouts#9681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes RaspberryPiFoundation/blockly-keyboard-experimentation#429
Proposed Changes
This PR adjusts the navigation logic in the toolbox and flyout navigators to take into account (a) toolbox/flyout placement at the left/right/top/bottom of the workspace and (b) LTR vs RTL to ensure that keyboard navigation between the toolbox and flyout using the arrow keys does the sensible thing with any allowed layout. I manually verified the behavior for every workspace on the multiplayground. Tests were LLM-generated with human review and extensive modification.