ci: fix preview URLs on dependabot/forks #1327
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nihalgonsalves
force-pushed
the
ng/01-15-ci_fix_preview_urls_on_dependabot_forks
branch
from
1135775 to
98ffd34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Description / Changes introduced
Both forks and dependabot don't create preview URLs.
Add explicit permissions plus use
pull_request_targetto allow writing from forks.pull_request_target runs in the context of the base branch, so can be unsafe if you check out code from the fork, therefore running untrusted code with secrets/other access available to GitHub Actions.
Since we're only adding an annotation, this is safe.
Links to discussion, or Linear ticket (if applicable)
Additional comments