Avoids consuming purchases by default #3003
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3003 +/- ##
=======================================
Coverage 78.84% 78.84%
=======================================
Files 338 338
Lines 13209 13209
Branches 1791 1791
=======================================
Hits 10415 10415
Misses 2047 2047
Partials 747 747 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ?.firstOrNull() | ||
| ?.shouldConsume | ||
| ?: true | ||
| ?: false |
There was a problem hiding this comment.
One thing that I think could be important... In this scenario, where it gets to this default, we shouldn't add the token to the cache of successfully posted tokens so we retry to post it on next app foreground. This way, if it was meant to be a consumable, we wouldn't have the issue of it not being able to be repurchased much longer. Wdyt?
tonidero
left a comment
tonidero
left a comment
There was a problem hiding this comment.
I think my comment is not a blocker. This is already better, so approving as it is. We can handle my comment separately
Description
In case a backend bug would respond incomplete product data upon POST /receipt, we would default to consume. This PR switches that to default to not consume, which is less destructive. (To be clear, such a backend bug has never happened, but better safe than sorry.)
Resolves #3001