Unused parens #4368
Open
Unused parens #4368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasly-ba
force-pushed
the
unused-parens
branch
from
97fb791 to
5ceb339
Compare
Member
|
Hello! ChangeLog nitpicker here 😅 Note that for the case above, you're adding the method, so you can simply use: The other entries can also be cleaned up (i.e. adding the full "path" to the modified thing and maybe using 'New'). Can you fix that small nit? :) Thanks! |
lucasly-ba
force-pushed
the
unused-parens
branch
from
5ceb339 to
53a9818
Compare
gcc/rust/ChangeLog: * checks/lints/unused/rust-unused-checker.cc (UnusedChecker::visit): Visit GroupExpr and add unused parens warning if not necessary. * checks/lints/unused/rust-unused-checker.h: New. * checks/lints/unused/rust-unused-collector.cc (UnusedCollector::visit): Check if a grouped expr in arithmetical or boolean expr is used. * checks/lints/unused/rust-unused-collector.h: New. * checks/lints/unused/rust-unused-context.cc (UnusedContext::add_group): Method helper. (UnusedContext::is_group_used): Likewise. * checks/lints/unused/rust-unused-context.h: Likewise. gcc/testsuite/ChangeLog: * rust/compile/unused-parens_0.rs: New test. Signed-off-by: Lucas Ly Ba <[email protected]>
lucasly-ba
force-pushed
the
unused-parens
branch
from
53a9818 to
a18f230
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.