cmov: add asm! optimized masknz32 for ARM32
#1336
Merged
+24
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1332 we ran into LLVM inserting branches in this routine for
thumbv6m-none-eabitargets. It was "fixed" by fiddling around withblack_boxbut that seems brittle.In #1334 we attempted a simple portable
asm!optimization barrier approach but it did not work as expected.This instead opts to implement one of the fiddliest bits, mask generation, using ARM assembly instead. The resulting assembly is actually more efficient than what rustc/LLVM outputs and avoids touching the stack pointer.
It's a simple enough function to implement in assembly on other platforms with stable
asm!too, but this is a start.