Skip to content

[Performance] Memoize isVerbose and isUnitTest in local context#7566

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
jules-performance-memoize-env-checks-7311632441309857235
Draft

[Performance] Memoize isVerbose and isUnitTest in local context#7566
gonzaloriestra wants to merge 1 commit into
mainfrom
jules-performance-memoize-env-checks-7311632441309857235

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

@gonzaloriestra gonzaloriestra commented May 17, 2026

WHY are these changes introduced?

Performance-obsessed optimization for hot paths. Environment checks like isVerbose and isUnitTest are static during the execution of a CLI command but are often checked repeatedly (e.g., in every outputDebug call).

WHAT is this pull request doing?

This PR implements lazy-initialized memoization for isVerbose and isUnitTest in packages/cli-kit/src/public/node/context/local.ts.

  • Adds memoizedIsVerbose and memoizedIsUnitTest module-level variables.
  • Implements a check to ensure memoization only occurs when using process.env.
  • Bypasses the cache when a custom env object is passed (crucial for unit tests).
  • Adds comments explaining the rationale and safety of the optimization.

How to test your changes?

CI

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 7311632441309857235 started by @gonzaloriestra

@gonzaloriestra
[Performance] Memoize isVerbose and isUnitTest in local context
62d5fcb 
Memoize the result of `isVerbose` and `isUnitTest` when called with
`process.env`. These checks are performed frequently in hot paths
like logging (`outputDebug`), and memoizing them avoids repeated
`process.argv.includes` scans and redundant environment variable
lookups.

The memoization explicitly bypasses the cache when a custom environment
object is provided, ensuring test isolation remains intact.

Performance impact:
- Reduces overhead in high-frequency logging paths.
- Avoids O(N) array scans for the `--verbose` flag on every debug log.
@google-labs-jules
Copy link
Copy Markdown

google-labs-jules Bot commented May 17, 2026

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gonzaloriestra