Skip to content

Add vid/pid of the Nordic Reference Lock to new-matter-lock#2995

Open
markaj-nordic wants to merge 1 commit into
SmartThingsCommunity:mainfrom
markaj-nordic:feature/add-nordicsemi-lock
Open

Add vid/pid of the Nordic Reference Lock to new-matter-lock#2995
markaj-nordic wants to merge 1 commit into
SmartThingsCommunity:mainfrom
markaj-nordic:feature/add-nordicsemi-lock

Conversation

@markaj-nordic
Copy link
Copy Markdown

@markaj-nordic markaj-nordic commented May 22, 2026 •
edited
Loading

  • updated fingerprints.lua file
  • updated fingerprints.yml file

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 22, 2026 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026 •
edited
Loading

Test Results

   73 files    512 suites   0s ⏱️
2 898 tests 2 898 ✅ 0 💤 0 ❌
4 770 runs  4 770 ✅ 0 💤 0 ❌

Results for commit dc6f1f0.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026 •
edited
Loading

File Coverage
All files 81% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/can_handle.lua 90% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua 79% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lazy_load_subdriver.lua 57% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 68% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 92% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against dc6f1f0

@tpmanley tpmanley force-pushed the feature/add-nordicsemi-lock branch from 2ae9605 to dc6f1f0 Compare May 22, 2026 20:21
tpmanley
tpmanley reviewed May 22, 2026
View reviewed changes
Comment thread drivers/SmartThings/matter-lock/fingerprints.yml Outdated
@tpmanley
Copy link
Copy Markdown
Contributor

tpmanley commented May 22, 2026

The invitation link isn't be added because there is an issue with the changes to the fingerprints.yml file which I commented on. If you remove that change the link should be created once that workflow is able to run successfully.

@markaj-nordic
Add vid/pid of the Nordic Reference Lock to new-matter-lock
d565c26 
- updated fingerprints.lua file
- updated fingerprints.yml file

Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no>
@markaj-nordic markaj-nordic force-pushed the feature/add-nordicsemi-lock branch from dc6f1f0 to d565c26 Compare May 22, 2026 21:56
@markaj-nordic
Copy link
Copy Markdown
Author

markaj-nordic commented May 22, 2026

The invitation link isn't be added because there is an issue with the changes to the fingerprints.yml file which I commented on. If you remove that change the link should be created once that workflow is able to run successfully.

Ok, thanks for the hint. Done.

@markaj-nordic
Copy link
Copy Markdown
Author

markaj-nordic commented May 22, 2026

@tpmanley looks like the workflow is still blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tpmanley tpmanley tpmanley left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markaj-nordic @CLAassistant @tpmanley