Skip to content

Fix Someday hover times on week grid#1806

Merged
Uarmagan merged 7 commits into
mainfrom
fix/someday-grid-hover-times
May 20, 2026
Merged

Fix Someday hover times on week grid#1806
Uarmagan merged 7 commits into
mainfrom
fix/someday-grid-hover-times

Conversation

@Uarmagan
Copy link
Copy Markdown
Contributor

@Uarmagan Uarmagan commented May 20, 2026

Summary

Fixes #1801.

When a Someday event is dragged from the sidebar onto the Timed Grid, the hover preview now uses the same visual structure as a Timed Event: the title starts at the top and the time appears underneath it.

The preview always shows the tentative time while the event is hovering over the grid, including when the target time is already in the past. That gives the user constant feedback about the slot they are aiming for while dragging.

The saved Timed Event now shares the same title/time text treatment as the Someday preview, so the handoff after drop does not visually change the typography or spacing. Future events keep the time visible. Past events hide the time after drop, and Someday drops into past slots animate the time up and out so the transition feels intentional instead of abrupt.

This also covers the related saved timed-event drag path: if a past saved Timed Event starts from a final state that does not render a time label, its drag clone creates a temporary time label while moving so the user can still place it accurately.

The acceptance runbook documents the split between hover-preview behavior and final saved-event behavior.

Verification

  • bun test src/views/Week/interaction/adapter/WeekInteractionAdapter.timedDrag.test.ts src/components/PlannerSidebar/SomedayEventSections/interaction/adapter/SomedayInteractionAdapter.test.ts src/views/Week/interaction/registry/weekEventRegistry.test.tsx
  • bunx playwright test e2e/someday/drag-someday-event-mouse.spec.ts --project=chromium-desktop
  • bun type-check
  • bun lint
  • bunx react-doctor@latest . --verbose --diff

@Uarmagan Uarmagan merged commit f15c578 into main May 20, 2026
9 checks passed
@Uarmagan Uarmagan deleted the fix/someday-grid-hover-times branch May 20, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing times when hovering someday event over grid

1 participant