Fix Someday hover times on week grid#1806
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1801.
When a Someday event is dragged from the sidebar onto the Timed Grid, the hover preview now uses the same visual structure as a Timed Event: the title starts at the top and the time appears underneath it.
The preview always shows the tentative time while the event is hovering over the grid, including when the target time is already in the past. That gives the user constant feedback about the slot they are aiming for while dragging.
The saved Timed Event now shares the same title/time text treatment as the Someday preview, so the handoff after drop does not visually change the typography or spacing. Future events keep the time visible. Past events hide the time after drop, and Someday drops into past slots animate the time up and out so the transition feels intentional instead of abrupt.
This also covers the related saved timed-event drag path: if a past saved Timed Event starts from a final state that does not render a time label, its drag clone creates a temporary time label while moving so the user can still place it accurately.
The acceptance runbook documents the split between hover-preview behavior and final saved-event behavior.
Verification
bun test src/views/Week/interaction/adapter/WeekInteractionAdapter.timedDrag.test.ts src/components/PlannerSidebar/SomedayEventSections/interaction/adapter/SomedayInteractionAdapter.test.ts src/views/Week/interaction/registry/weekEventRegistry.test.tsxbunx playwright test e2e/someday/drag-someday-event-mouse.spec.ts --project=chromium-desktopbun type-checkbun lintbunx react-doctor@latest . --verbose --diff