[codex] Restore logout confirmation#1836
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Zshortcut and command-palette logout action.Why
PR #1794 removed the old
/logoutroute. That route used to require a separate Signout button, but after it was removed theZshortcut called logout immediately. This restores the missing user consent step without bringing the route back.Validation
bun test src/components/LogoutConfirmation/LogoutConfirmationDialog.test.tsx src/views/Week/hooks/shortcuts/useGlobalShortcuts.test.tsx src/common/hooks/useLogoutCmdItems.test.ts src/auth/compass/hooks/useLogout.test.tsbun type-checkbun run build:webZopens the confirmation, Cancel keeps the user signed in, and Log out clears auth stateNotes
bun lintis currently blocked by unrelated local changes under skill folders; the touched files pass focused lint.