Skip to content

[codex] Restore logout confirmation#1836

Merged
Uarmagan merged 5 commits into
mainfrom
codex/restore-logout-confirmation
May 31, 2026
Merged

[codex] Restore logout confirmation#1836
Uarmagan merged 5 commits into
mainfrom
codex/restore-logout-confirmation

Conversation

@Uarmagan
Copy link
Copy Markdown
Contributor

What changed

  • Adds a logout confirmation dialog for the global Z shortcut and command-palette logout action.
  • Keeps logout itself in the existing logout hook, but routes shortcut and palette logout through the confirmation step first.
  • Improves the shared overlay panel so the confirmation behaves like a real dialog for focus and labels.

Why

PR #1794 removed the old /logout route. That route used to require a separate Signout button, but after it was removed the Z shortcut called logout immediately. This restores the missing user consent step without bringing the route back.

Validation

  • bun test src/components/LogoutConfirmation/LogoutConfirmationDialog.test.tsx src/views/Week/hooks/shortcuts/useGlobalShortcuts.test.tsx src/common/hooks/useLogoutCmdItems.test.ts src/auth/compass/hooks/useLogout.test.ts
  • bun type-check
  • bun run build:web
  • Focused Biome check on the touched files
  • Browser smoke against a fresh local build: Z opens the confirmation, Cancel keeps the user signed in, and Log out clears auth state

Notes

  • Full bun lint is currently blocked by unrelated local changes under skill folders; the touched files pass focused lint.

@Uarmagan Uarmagan marked this pull request as ready for review May 31, 2026 15:01
@Uarmagan Uarmagan merged commit 4987de9 into main May 31, 2026
9 checks passed
@Uarmagan Uarmagan deleted the codex/restore-logout-confirmation branch May 31, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant