devtools move production exports to dedicated subdirectory #1989
+28
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 856872c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 856872c
☁️ Nx Cloud last updated this comment at |
Contributor
|
This makes sense to me, can you add a change set to the PR? |
Moved production exports of devtools to a dedicated subdirectory.
Member
Author
|
@harry-whorlow should I apply these changes to the Solid devtools as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The leaf packages (i.e
@tanstack/react-form-devtools) being pointed at the same import for development, causes issues when building the devtools for production.Since, the panel and plugin in React package point their imports at the apex of the root package (
form-devtool), and not the/productionbranch, it means that whenever a production build is initiated, the export conditions for production in the form devtools core package are never hit, which in turn erases the panel from being present in production.Closes #1986
🎯 Changes
✅ Checklist
pnpm test:pr.🚀 Release Impact