-
-
Notifications
You must be signed in to change notification settings - Fork 11
Issue fixes #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Issue fixes #130
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
33c537e
harden PnP and nested dependency discovery
LadyBluenotes 351a0f1
use project package runner in guidance
LadyBluenotes 4bbe00d
keep runner formatting out of core
LadyBluenotes fd53db8
bound nested dependency discovery
LadyBluenotes 13e1740
ci: apply automated fixes
autofix-ci[bot] a38c94f
optimize scanner identity and package manager detection
LadyBluenotes 7644c5f
ci: apply automated fixes
autofix-ci[bot] f2084d7
walk nested fallback dependencies
LadyBluenotes 2da2d15
ci: apply automated fixes
autofix-ci[bot] 723ec4d
changeset
LadyBluenotes ac92769
docs update
LadyBluenotes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@tanstack/intent': patch | ||
| --- | ||
|
|
||
| Fix package discovery for Yarn PnP projects and pnpm symlinked dependency trees, and use the detected package manager when printing Intent commands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import { detectPackageManager } from './package-manager.js' | ||
| import type { PackageManager } from './types.js' | ||
|
|
||
| export { detectPackageManager as detectIntentCommandPackageManager } | ||
|
|
||
| const runnerByPackageManager: Record<PackageManager, string> = { | ||
| bun: 'bunx @tanstack/intent@latest', | ||
| npm: 'npx @tanstack/intent@latest', | ||
| pnpm: 'pnpm dlx @tanstack/intent@latest', | ||
| unknown: 'npx @tanstack/intent@latest', | ||
| yarn: 'yarn dlx @tanstack/intent@latest', | ||
| } | ||
|
|
||
| export function formatIntentCommand( | ||
| packageManager: PackageManager, | ||
| args: string, | ||
| ): string { | ||
| const command = runnerByPackageManager[packageManager] | ||
| const trimmedArgs = args.trim() | ||
| return trimmedArgs ? `${command} ${trimmedArgs}` : command | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.