Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughBumped dependencies in two packages; requestHandler now catches URIError when creating H3Event and retries with a sanitized request path; getCookies() filters out undefined values; several e2e modules switched to add default exports and adjusted imports/exports. Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 775bde6
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version Preview2 package(s) bumped directly, 20 bumped as dependents. 🟩 Patch bumps
|
Bundle Size Benchmarks
Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/start-server-core/src/request-response.ts`:
- Around line 307-315: The cookie map uses a plain object (definedCookies) which
inherits Object.prototype and can expose prototype keys; change its creation to
a null-prototype object (e.g., use Object.create(null) for definedCookies) so
only actual cookie keys are present, keep the same filtering logic in the
for-loop over Object.entries(cookies), and ensure the variable's type remains
compatible with Record<string, string> (narrow or cast as needed) to satisfy
TypeScript strict mode.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 53cb6800-ed2a-4033-81fd-e93e793856cd
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
packages/start-server-core/src/request-response.ts
| } | ||
| } | ||
|
|
||
| export const users: Array<User> = [ |
There was a problem hiding this comment.
why was this changed?
There was a problem hiding this comment.
It was because the CI failed in this run (the commit before i "fix dummy erver imports") because of the exports
https://github.com/TanStack/router/actions/runs/24258504702/job/70836128095
| body: string | ||
| } | ||
|
|
||
| export const posts: Array<Post> = [ |
There was a problem hiding this comment.
why was this changed?
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud has identified a possible root cause for your failed CI:
We identified the failure in tanstack-router-e2e-react-escaped-special-strings:test:e2e as an environment issue, not a regression introduced by our changes. The Chromium headless browser crashed with a SIGSEGV (signal 11 / General Protection Fault) due to a missing system DBus socket (/run/dbus/system_bus_socket) in the CI environment, causing only the first of 13 tests to fail. This project is not touched by our PR, and the crash is unrelated to the h3/cookie-es dependency bumps.
No code changes were suggested for this issue.
Trigger a rerun:
🎓 Learn more about Self-Healing CI on nx.dev
Bumps
h3-v2to2.0.1-rc.20andcookie-esto v3.This needs a small
@tanstack/start-server-coreupdate because both bumps change behavior that Start currently relies on:parseCookies()now returnsRecord<string, string | undefined>, so Start needs to filter outundefinedvalues to preserve the existinggetCookies(): Record<string, string>APISummary by CodeRabbit
Chores
Bug Fixes
Tests