fix(angular): fix conditional flexRenderComponent rendering#6218
fix(angular): fix conditional flexRenderComponent rendering#6218riccardoperra wants to merge 1 commit intomainfrom
Conversation
This resolve a rendering issue with flexRenderDirective that doesn't re-render component while using conditional flexRenderComponent return in column configuration
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 3f6ede2
☁️ Nx Cloud last updated this comment at |
This resolve a rendering issue with flexRenderDirective that doesn't re-render component while using conditional flexRenderComponent return in the same cell column configuration (same cell reference in template, so it's a case where you are not updating table state but relies on external data outside of table scope)
Example:
Results
before: no-rerender since we were checking only A and B content type (which is always flexRenderComponent)
after: A will be destroyed and B will be created (since component type class is different)