Skip to content

feat(maintainers): add 'Wonsuk Choi' as 'query' maintainer#778

Open
sukvvon wants to merge 1 commit intoTanStack:mainfrom
sukvvon:chore/add-wonsuk-choi-maintainer
Open

feat(maintainers): add 'Wonsuk Choi' as 'query' maintainer#778
sukvvon wants to merge 1 commit intoTanStack:mainfrom
sukvvon:chore/add-wonsuk-choi-maintainer

Conversation

@sukvvon
Copy link

@sukvvon sukvvon commented Mar 21, 2026

Add Wonsuk Choi (@sukvvon) to the maintainers list as a query maintainer.

Summary by CodeRabbit

  • Chores
    • Added a new team maintainer (React expertise) with specialties in TypeScript and testing, assigned to query-related components, and included social/profile links.

@netlify
Copy link

netlify bot commented Mar 21, 2026

👷 Deploy request for tanstack pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a655740

@coderabbitai
Copy link

coderabbitai bot commented Mar 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 92fddadf-cf2c-4cd9-b836-4c6ee4acabce

📥 Commits

Reviewing files that changed from the base of the PR and between eb05116 and a655740.

📒 Files selected for processing (1)
  • src/libraries/maintainers.ts
✅ Files skipped from review due to trivial changes (1)
  • src/libraries/maintainers.ts

📝 Walkthrough

Walkthrough

A new maintainer entry for Wonsuk Choi was added to the allMaintainers array with metadata including GitHub profile, React framework expertise, TypeScript and testing specialties, and social media links.

Changes

Cohort / File(s) Summary
New Maintainer Entry
src/libraries/maintainers.ts
Added new maintainer record for Wonsuk Choi with avatar (https://github.com/sukvvon.png), GitHub handle sukvvon, maintainerOf: ['query'], frameworkExpertise: ['react'], specialties: ['TypeScript', 'Test'], and social links (LinkedIn, Twitter/X, Bluesky).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A new friend hops into our team today,
Wonsuk joins to help us code and play,
With React skills and TypeScript so fine,
Testing expertise that brightly will shine,
Welcome aboard, let's build something divine!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding Wonsuk Choi as a query maintainer to the maintainers list.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/libraries/maintainers.ts`:
- Around line 290-302: The social links for the maintainer entry with name
'Wonsuk Choi' need correction: verify and replace the values in the social
object (linkedIn, twitter, bluesky) with the correct, accessible profile URLs or
remove a field if the account does not exist; also confirm whether the avatar
value 'https://github.com/sukvvon.png' should remain (it currently redirects)
and replace it with a direct image URL if a non-redirecting avatar is required.
Locate the maintainer object (name: 'Wonsuk Choi') in
src/libraries/maintainers.ts and update social.linkedIn, social.twitter,
social.bluesky and avatar accordingly so each URL returns a 200 and matches the
intended profile.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4d70490c-ab6d-4364-a37f-9b1d17e46a50

📥 Commits

Reviewing files that changed from the base of the PR and between 445cd00 and eb05116.

📒 Files selected for processing (1)
  • src/libraries/maintainers.ts

Comment on lines +290 to +302
{
name: 'Wonsuk Choi',
avatar: 'https://github.com/sukvvon.png',
github: 'sukvvon',
maintainerOf: ['query'],
frameworkExpertise: ['react'],
specialties: ['TypeScript', 'Test'],
social: {
linkedIn: 'https://www.linkedin.com/in/sukvvon',
twitter: 'https://x.com/sukvvon',
bluesky: 'https://bsky.app/profile/sukvvon.bsky.social',
},
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify that all URLs in the new maintainer entry are accessible

echo "Checking GitHub profile and avatar..."
curl -sI "https://github.com/sukvvon" | head -n 1
curl -sI "https://github.com/sukvvon.png" | head -n 1

echo -e "\nChecking social media links..."
curl -sI "https://www.linkedin.com/in/sukvvon" | head -n 1
curl -sI "https://x.com/sukvvon" | head -n 1
curl -sI "https://bsky.app/profile/sukvvon.bsky.social" | head -n 1

Repository: TanStack/tanstack.com

Length of output: 198


Verify and fix social media links in the maintainer entry.

The code structure is correct and follows the established pattern, but URL verification revealed issues with the social media links:

  • Bluesky URL returns 404: https://bsky.app/profile/sukvvon.bsky.social does not exist. Please verify the correct Bluesky profile URL.
  • X.com URL returns 403: https://x.com/sukvvon is blocked/forbidden. Please verify this URL is correct.
  • LinkedIn URL returns 999: https://www.linkedin.com/in/sukvvon returned an access-denied response. Please verify this URL is accessible.
  • Avatar URL returns 302: https://github.com/sukvvon.png redirects instead of serving directly. This may work but should be confirmed as the intended format.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/libraries/maintainers.ts` around lines 290 - 302, The social links for
the maintainer entry with name 'Wonsuk Choi' need correction: verify and replace
the values in the social object (linkedIn, twitter, bluesky) with the correct,
accessible profile URLs or remove a field if the account does not exist; also
confirm whether the avatar value 'https://github.com/sukvvon.png' should remain
(it currently redirects) and replace it with a direct image URL if a
non-redirecting avatar is required. Locate the maintainer object (name: 'Wonsuk
Choi') in src/libraries/maintainers.ts and update social.linkedIn,
social.twitter, social.bluesky and avatar accordingly so each URL returns a 200
and matches the intended profile.

@sukvvon sukvvon force-pushed the chore/add-wonsuk-choi-maintainer branch from eb05116 to a655740 Compare March 22, 2026 03:55
@sukvvon sukvvon changed the title chore(maintainers): add 'Wonsuk Choi' as 'query' maintainer feat(maintainers): add 'Wonsuk Choi' as 'query' maintainer Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant