feat(maintainers): add 'Wonsuk Choi' as 'query' maintainer#778
feat(maintainers): add 'Wonsuk Choi' as 'query' maintainer#778sukvvon wants to merge 1 commit intoTanStack:mainfrom
Conversation
👷 Deploy request for tanstack pending review.Visit the deploys page to approve it
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughA new maintainer entry for Wonsuk Choi was added to the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/libraries/maintainers.ts`:
- Around line 290-302: The social links for the maintainer entry with name
'Wonsuk Choi' need correction: verify and replace the values in the social
object (linkedIn, twitter, bluesky) with the correct, accessible profile URLs or
remove a field if the account does not exist; also confirm whether the avatar
value 'https://github.com/sukvvon.png' should remain (it currently redirects)
and replace it with a direct image URL if a non-redirecting avatar is required.
Locate the maintainer object (name: 'Wonsuk Choi') in
src/libraries/maintainers.ts and update social.linkedIn, social.twitter,
social.bluesky and avatar accordingly so each URL returns a 200 and matches the
intended profile.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4d70490c-ab6d-4364-a37f-9b1d17e46a50
📒 Files selected for processing (1)
src/libraries/maintainers.ts
| { | ||
| name: 'Wonsuk Choi', | ||
| avatar: 'https://github.com/sukvvon.png', | ||
| github: 'sukvvon', | ||
| maintainerOf: ['query'], | ||
| frameworkExpertise: ['react'], | ||
| specialties: ['TypeScript', 'Test'], | ||
| social: { | ||
| linkedIn: 'https://www.linkedin.com/in/sukvvon', | ||
| twitter: 'https://x.com/sukvvon', | ||
| bluesky: 'https://bsky.app/profile/sukvvon.bsky.social', | ||
| }, | ||
| }, |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify that all URLs in the new maintainer entry are accessible
echo "Checking GitHub profile and avatar..."
curl -sI "https://github.com/sukvvon" | head -n 1
curl -sI "https://github.com/sukvvon.png" | head -n 1
echo -e "\nChecking social media links..."
curl -sI "https://www.linkedin.com/in/sukvvon" | head -n 1
curl -sI "https://x.com/sukvvon" | head -n 1
curl -sI "https://bsky.app/profile/sukvvon.bsky.social" | head -n 1Repository: TanStack/tanstack.com
Length of output: 198
Verify and fix social media links in the maintainer entry.
The code structure is correct and follows the established pattern, but URL verification revealed issues with the social media links:
- Bluesky URL returns 404:
https://bsky.app/profile/sukvvon.bsky.socialdoes not exist. Please verify the correct Bluesky profile URL. - X.com URL returns 403:
https://x.com/sukvvonis blocked/forbidden. Please verify this URL is correct. - LinkedIn URL returns 999:
https://www.linkedin.com/in/sukvvonreturned an access-denied response. Please verify this URL is accessible. - Avatar URL returns 302:
https://github.com/sukvvon.pngredirects instead of serving directly. This may work but should be confirmed as the intended format.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/libraries/maintainers.ts` around lines 290 - 302, The social links for
the maintainer entry with name 'Wonsuk Choi' need correction: verify and replace
the values in the social object (linkedIn, twitter, bluesky) with the correct,
accessible profile URLs or remove a field if the account does not exist; also
confirm whether the avatar value 'https://github.com/sukvvon.png' should remain
(it currently redirects) and replace it with a direct image URL if a
non-redirecting avatar is required. Locate the maintainer object (name: 'Wonsuk
Choi') in src/libraries/maintainers.ts and update social.linkedIn,
social.twitter, social.bluesky and avatar accordingly so each URL returns a 200
and matches the intended profile.
eb05116 to
a655740
Compare
Add Wonsuk Choi (
@sukvvon) to the maintainers list as aquerymaintainer.Summary by CodeRabbit