fix(routes/examples): remove fixed 'h-[95dvh]' breaking Safari render#973
Merged
Conversation
📝 WalkthroughWalkthroughA single CSS class is removed from the examples route's main container element. The ChangesExamples Container Styling
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the fixed
h-[95dvh]height from the examples page scroll container, which prevented the embedded code example viewer from rendering in Safari.Problem
On example pages, the interactive code explorer rendered correctly in Chrome but collapsed in Safari. The scroll container used a fixed
h-[95dvh]inside amd:flex-rowflex layout. WebKit miscalculated this fixeddvhheight, collapsing the container to ~79px while its content was ~1005px tall. Theoverflow-autothen clipped everything below the collapsed height.Fix
The container already receives its height from the parent flex layout via
flex-1 min-h-0, soh-[95dvh]was redundant in Chrome (height unchanged) and harmful in Safari. Verified the fix renders correctly in both Safari and Chrome.Screenshot
AS-IS
Safari
Chrome
TO-BE
Safari
Chrome
Summary by CodeRabbit