feat: add progressive_set_intersection to disjoint_set#14491
Closed
Devanik21 wants to merge 2 commits intoTheAlgorithms:masterfrom
Closed
feat: add progressive_set_intersection to disjoint_set#14491Devanik21 wants to merge 2 commits intoTheAlgorithms:masterfrom
Devanik21 wants to merge 2 commits intoTheAlgorithms:masterfrom
Conversation
This function computes the intersection of multiple sets efficiently by sorting them by size and using early termination.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This PR adds
progressive_set_intersection()todata_structures/disjoint_set/.Problem it addresses
Python's built-in
set.intersection(*others)is already highly optimized in C. However, when intersecting many sets (50–100+) or dealing with highly imbalanced sizes (e.g., one set with 10 elements vs. multiple sets with millions of elements), repeatedly doing membership checks can be improved by strategic ordering and early pruning.This implementation demonstrates the "smallest-first + progressive pruning" heuristic:
This pattern significantly reduces unnecessary work in practice for the edge cases discussed in #14368.
Why add this?
Note: For general use cases, Python's built-in
set.intersection()is still recommended. This module is mainly for learning and teaching the "prune early" strategy.Algorithm Details
kis the number of sets, but much faster in practice due to sorting + early pruning.Related Issue
Closes #14368
Files Changed
data_structures/disjoint_set/progressive_set_intersection.py(new file)Testing
python -m doctest -v progressive_set_intersection.pyExample Usage
Would be happy to add sorted_array_intersection (two-pointer technique) or a bitmap version in a follow-up PR.
Thanks to @Starglen and @dinakars777 for the valuable discussion in the original issue!