Skip to content

Fix incorrect handling of zero input in binary_count_trailing_zeros#14494

Closed
satwik-exe wants to merge 2 commits intoTheAlgorithms:masterfrom
satwik-exe:fix-trailing-zeros-zero-input
Closed

Fix incorrect handling of zero input in binary_count_trailing_zeros#14494
satwik-exe wants to merge 2 commits intoTheAlgorithms:masterfrom
satwik-exe:fix-trailing-zeros-zero-input

Conversation

@satwik-exe
Copy link
Copy Markdown

Description

Fixed incorrect behavior for input value 0 in binary_count_trailing_zeros.

Changes Made

  • Added explicit check for a == 0 and raised ValueError
  • Improved type validation using isinstance
  • Updated doctests accordingly

Why This Fix?

Previously, the function returned 0 for input 0, which is misleading and mathematically incorrect.

Testing

  • Verified all doctests pass successfully

@algorithms-keeper
Copy link
Copy Markdown

Closing this pull request as invalid

@satwik-exe, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper bot added invalid awaiting reviews This PR is ready to be reviewed labels Apr 1, 2026
@algorithms-keeper algorithms-keeper bot closed this Apr 1, 2026
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant