[codex] Improve PDF generation UX#160
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying markdown-viewer with
|
| Latest commit: |
c55f68e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f6a1f8cb.markdown-viewer.pages.dev |
| Branch Preview URL: | https://codex-improve-pdf-generation.markdown-viewer.pages.dev |
Deploying markdownviewer with
|
| Latest commit: |
c55f68e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://79605262.markdownviewer.pages.dev |
| Branch Preview URL: | https://codex-improve-pdf-generation.markdownviewer.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The previous PDF export flow updated the button and overlay inline, then duplicated cleanup across success and error paths. The error path looked for an overlay style string that did not match the created overlay, so state could remain stuck. Long-running generation also had no user-visible progress beyond a static message and no cancellation path before saving.
User Impact
Users now see meaningful PDF generation progress, can cancel an export, and can run multiple PDF exports in one session without refreshing the page. Cancelled exports clean up immediately and do not intentionally save a partial PDF.
Validation
node --check script.jsgit diff --check