Skip to content

add Allocation::name() getter#257

Open
Firestar99 wants to merge 2 commits into
Traverse-Research:mainfrom
Firestar99:get_name
Open

add Allocation::name() getter#257
Firestar99 wants to merge 2 commits into
Traverse-Research:mainfrom
Firestar99:get_name

Conversation

@Firestar99

Copy link
Copy Markdown

What the title says, nothing special. I don't want to store yet another copy of the same string, it would be nice if I could just query it instead.

@MarijnS95

Copy link
Copy Markdown
Member

Should the PR title be prefixed with vulkan: or are you intending to add this to the other backends (dx12 and Metal) as well?

@MarijnS95 MarijnS95 changed the title add Allocation::name getter add Allocation::name() getter Dec 24, 2024
@Jasper-Bekkers

Copy link
Copy Markdown
Member

Looking at this, does anyone know why it's name: Option<Box<str>> and not name: Option<String>?

@MarijnS95

MarijnS95 commented Jan 9, 2025

Copy link
Copy Markdown
Member

@Jasper-Bekkers that should be #70, which explains it's a minor reduction in struct size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants