Add CI check for min required version#1480
Draft
minion-workers[bot] wants to merge 1 commit intomainfrom
Draft
Conversation
Resolves #1458 Co-Authored-By: Claude <noreply@anthropic.com>
Author
|
Minion Review Gate: Starting review (round 1). Watch live |
Author
|
Minion Review Gate: Changes requested. The implementer agent will address the issues above. |
Author
|
Minion Feedback Agent completed
Agent SummaryAll checks are passing and there's no specific feedback to address — the review feedback fields are all empty. The PR is in good shape:
No changes needed. |
Author
|
Minion Worker reviewed the feedback but determined no code changes were needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1458
Done. Here's a summary of what was created:
New files
.github/scripts/check_min_required_version.py— CI check script that:git diff)>=X.Y.Z) matches the dependency's current version.github/scripts/test_check_min_required_version.py— 12 tests covering:parse_min_version: extracting min versions from dependency specifierscheck_min_versions: matching/outdated versions, skipping unchanged deps, multiple violationsmain: no changes, passing, and failing scenariosHow it works
When a PR modifies both
uipath-core(at version0.5.7) anduipath-platform(which depends onuipath-core>=0.5.4), the script fails because0.5.4 != 0.5.7, prompting the developer to update the minimum version to>=0.5.7.The script follows the same patterns as the existing
check_version_uniqueness.py(env vars, git diff, tomllib parsing).Changes
Files changed
Created by Minion Worker — autonomous Claude Code agent
To request changes, comment mentioning
@minion.