Do not double count control flow types #8196
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update a comment to better match the code and tweak a loop to avoid repeated work.
kripken
reviewed
Jan 13, 2026
src/ir/module-utils.cpp
Outdated
| // control flow types. Consider one more control flow type and repeat. | ||
| for (; controlFlowIt != info.controlFlowSignatures.end(); ++controlFlowIt) { | ||
| while (controlFlowIt != info.controlFlowSignatures.end()) { | ||
| auto& [sig, count] = *controlFlowIt; |
Member
There was a problem hiding this comment.
Suggested change
| auto& [sig, count] = *controlFlowIt; | |
| auto& [sig, count] = *controlFlowIt++; |
Why not increment here? Or on the line right after?
tlively
changed the title
tlively
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update a comment to better match the code and tweak a loop to avoid
repeated work. Not NFC because avoiding the double count of multivalue
control flow types changes type ordering.