Open
Conversation
Member
Author
|
Looks like this messes with the auto-update script for the lit test... hmm. Otherwise though this should be ready. |
tlively
reviewed
Mar 13, 2026
Comment on lines
+575
to
+578
| // Log it at the right time later using a lambda. Note that we can't just | ||
| // capture |value| for the lambda, as the loop modifies it. | ||
| (() => { | ||
| var global = value; |
Member
There was a problem hiding this comment.
Not surprised to be surprised once again by JS semantics. Even the var global = value is not enough to avoid the need for this outer lambda?
| try { | ||
| actualValue = global.value; | ||
| } catch (e) { | ||
| if (e.message.startsWith('get WebAssembly.Global.value')) { |
Member
There was a problem hiding this comment.
-
Can we check the type of the error rather than the message? Error messages are not standardized and may differ between implementations.
-
Maybe we should print something else to distinguish this case from an exported global actually containing null.
Comment on lines
+506
to
+508
| // Log the global's value. (We use "calling" here to match the output | ||
| // for calls, which simplifies the fuzzer.) | ||
| std::cout << "[fuzz-exec] calling " << exp->name << "\n"; |
Member
There was a problem hiding this comment.
Can we remove "calling" everywhere as a follow-up?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already exported globals in the fuzzer, but did not do anything with
them. This logs out their values, at the same time that we log out the
values returned from calling exported functions (and using the same
reordering etc.).