Skip to content

Fix: Buttons output in extra_tablenav are too tall #11224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hbhalodia wants to merge 5 commits into from
Closed

Fix: Buttons output in extra_tablenav are too tall #11224

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aea235b
Fix issue for button height on extranav in custom list
hbhalodia Mar 11, 2026
c73cabb
Merge branch 'trunk' into fix/issue-64796
hbhalodia Mar 11, 2026
4933132
Merge branch 'trunk' into fix/issue-64796
hbhalodia Mar 16, 2026
5bf8645
Merge branch 'trunk' into fix/issue-64796
hbhalodia Mar 25, 2026
2828ed6
Add other input types to match the 32px style
hbhalodia Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions src/wp-admin/css/forms.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,16 +538,34 @@ input[type="number"].tiny-text {
display: none;
}

.tablenav .actions select {
.wp-core-ui .tablenav input[type="text"],
.wp-core-ui .tablenav input[type="password"],
.wp-core-ui .tablenav input[type="date"],
.wp-core-ui .tablenav input[type="datetime"],
.wp-core-ui .tablenav input[type="datetime-local"],
.wp-core-ui .tablenav input[type="email"],
.wp-core-ui .tablenav input[type="month"],
.wp-core-ui .tablenav input[type="number"],
.wp-core-ui .tablenav input[type="search"],
.wp-core-ui .tablenav input[type="tel"],
.wp-core-ui .tablenav input[type="time"],
.wp-core-ui .tablenav input[type="url"],
.wp-core-ui .tablenav input[type="week"],
.wp-core-ui .tablenav select {
padding: 0 12px;
/* inherits font size 14px */
Copy link
Copy Markdown
Member

@mukeshpanchal27 mukeshpanchal27 Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share why we need this comment?

Copy link
Copy Markdown
Contributor

@joedolson joedolson Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems unnecessary, given that none of the other related contexts have a similar condition.

Copy link
Copy Markdown
Contributor

@joedolson joedolson Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing my mind; it's helpful, as it gives context for the comment on the line-height calculation.

It comes from the same block of CSS in forms.css, which this duplicates, but adjusting to the compact sizing.

Copy link
Copy Markdown
Author

@hbhalodia hbhalodia Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joedolson @mukeshpanchal27, Yes I have kept it consistent from the original CSS forms.css.

Copy link
Copy Markdown
Contributor

@joedolson joedolson Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* inherits font size 14px */

line-height: 2.14285714; /* 30px for 32px height with 14px font */
min-height: 32px;
}

.wp-core-ui .tablenav select {
float: left;
margin-right: 6px;
max-width: 12.5rem;
min-height: 32px;
line-height: 2.14285714; /* 30px for 32px height with 14px font */
padding: 0 24px 0 8px;
}

.tablenav .actions .button {
.wp-core-ui .tablenav .button {
min-height: 32px;
line-height: 2.30769231; /* 30px for 32px height with 13px font */
padding: 0 12px;
Expand Down
Loading