Skip to content

Formatting: Handle Unicode whitespace in wp_trim_words()#11258

Open
dan-zakirov wants to merge 1 commit intoWordPress:trunkfrom
dan-zakirov:trac-64552
Open

Formatting: Handle Unicode whitespace in wp_trim_words()#11258
dan-zakirov wants to merge 1 commit intoWordPress:trunkfrom
dan-zakirov:trac-64552

Conversation

@dan-zakirov
Copy link

This updates the word boundary handling on UTF-8 sites to use a Unicode-aware whitespace pattern, so ideographic spaces (U+3000), non-breaking spaces (U+00A0), and other Unicode whitespace characters are treated as word separators. This matches the behavior already used in the Gutenberg editor.

For non-UTF-8 sites, the previous regex is kept as a fallback.

Props sirlouen, wildworks.
Fixes #64552.

Trac ticket: https://core.trac.wordpress.org/ticket/64552

Use a Unicode-aware whitespace pattern for UTF-8 sites so that ideographic spaces (U+3000), non-breaking spaces (U+00A0), and other Unicode whitespace characters are treated as word separators, matching the behavior of the Gutenberg editor.

Non-UTF-8 sites retain the previous regex as a fallback.

Props SirLouen, wildworks.
Fixes #64552.
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props alexodiy.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant