Skip to content

RTC: Fix stuck "Join" link in post list when RTC lock expires #11346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shekharnwagh wants to merge 7 commits into from
+49 −17
Closed

RTC: Fix stuck "Join" link in post list when RTC lock expires #11346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d7e09ca
Fix "Join" link staying stuck after post lock expires.
shekharnwagh Mar 24, 2026
edbe78e
Use screen-reader-text for post list action link accessibility.
shekharnwagh Mar 24, 2026
0fdeeff
Reuse existing translatable strings for action link accessibility.
shekharnwagh Mar 24, 2026
00351ba
Use string concatenation for action link markup.
shekharnwagh Mar 24, 2026
ffe30e7
Use sprintf with multi-line template for action link markup.
shekharnwagh Mar 26, 2026
39f1ece
Add explanatory comment for action link toggle mechanism.
shekharnwagh Mar 26, 2026
c260aa2
Fix lint errors
shekharnwagh Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/wp-admin/css/list-tables.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,18 @@ tr.wp-locked .row-actions .trash {
display: block;
}

.join-action-text {
display: none;
}

.wp-collaborative-editing .edit-action-text {
display: none;
}

.wp-collaborative-editing .join-action-text {
display: inline;
}

#menu-locations-wrap .widefat {
width: 60%;
}
Expand Down
54 changes: 37 additions & 17 deletions src/wp-admin/includes/class-wp-posts-list-table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1491,24 +1491,44 @@ protected function handle_row_actions( $item, $column_name, $primary ) {
$title = _draft_or_post_title();

if ( $can_edit_post && 'trash' !== $post->post_status ) {
$is_rtc_locked = get_option( 'wp_collaboration_enabled' ) && wp_check_post_lock( $post->ID );
$is_rtc_enabled = (bool) get_option( 'wp_collaboration_enabled' );

$actions['edit'] = sprintf(
'<a href="%s" aria-label="%s">%s</a>',
get_edit_post_link( $post->ID ),
esc_attr(
sprintf(
$is_rtc_locked
/* translators: %s: Post title. */
? __( 'Join editing &#8220;%s&#8221;', 'post list' )
/* translators: %s: Post title. */
: __( 'Edit &#8220;%s&#8221;' ),
$title
)
),
/* translators: Action link text for a singular post in the post list. Can be any type of post. */
$is_rtc_locked ? _x( 'Join', 'post list' ) : __( 'Edit' )
);
/*
* When RTC is enabled, both "Edit" and "Join" labels are rendered.
* The visible label is toggled by CSS based on the row's
* `wp-collaborative-editing` class, which is added or removed by
* inline-edit-post.js in response to heartbeat ticks.
*/
if ( $is_rtc_enabled ) {
$actions['edit'] = sprintf(
'<a href="%1$s">'
. '<span class="edit-action-text">'
. '<span aria-hidden="true">%2$s</span>'
. '<span class="screen-reader-text">%3$s</span>'
. '</span>'
. '<span class="join-action-text">'
. '<span aria-hidden="true">%4$s</span>'
. '<span class="screen-reader-text">%5$s</span>'
. '</span>'
. '</a>',
get_edit_post_link( $post->ID ),
__( 'Edit' ),
/* translators: %s: Post title. */
sprintf( __( 'Edit &#8220;%s&#8221;' ), $title ),
/* translators: Action link text for a singular post in the post list. Can be any type of post. */
_x( 'Join', 'post list' ),
/* translators: %s: Post title. */
sprintf( __( 'Join editing &#8220;%s&#8221;', 'post list' ), $title )
);
} else {
$actions['edit'] = sprintf(
'<a href="%s" aria-label="%s">%s</a>',
get_edit_post_link( $post->ID ),
/* translators: %s: Post title. */
esc_attr( sprintf( __( 'Edit &#8220;%s&#8221;' ), $title ) ),
__( 'Edit' )
);
}

/**
* Filters whether Quick Edit should be enabled for the given post type.
Expand Down
Loading