Script Loader: Warn when classic scripts depend on modules without footer/defer#11788
Script Loader: Warn when classic scripts depend on modules without footer/defer#11788itzmekhokan wants to merge 1 commit into
Conversation
…oter/defer. Scripts registered or enqueued with a `module_dependencies` arg may evaluate before the script modules import map is printed if they are loaded blocking in the document head, causing a "Failed to resolve module specifier" error on dynamic imports. Trigger `_doing_it_wrong()` from `_wp_scripts_add_args_data()` when a classic script provides `module_dependencies` without setting `in_footer` to true or using a `defer` loading `strategy`, and document this requirement in the `wp_register_script()` and `wp_enqueue_script()` docblocks. Existing tests in `wpScriptModules.php` that exercised this path are updated to use `in_footer => true` so they continue to validate the import map behavior without tripping the new warning. See #65165, #61500. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Scripts registered or enqueued with a
module_dependenciesarg may evaluate before the script modules import map is printed if they are loaded blocking in the document head, causing a "Failed to resolve module specifier" error on dynamic imports.Trigger
_doing_it_wrong()from_wp_scripts_add_args_data()when a classic script providesmodule_dependencieswithout settingin_footerto true or using adeferloadingstrategy, and document this requirement in thewp_register_script()andwp_enqueue_script()docblocks.Existing tests in
wpScriptModules.phpthat exercised this path are updated to usein_footer => trueso they continue to validate the import map behavior without tripping the new warning.See #65165, #61500.
Trac ticket: https://core.trac.wordpress.org/ticket/65165