Skip to content

Editor: adjust grid layout for filters#11885

Open
KhushalSainS wants to merge 2 commits into
WordPress:trunkfrom
KhushalSainS:fix/media-filter-alignment
Open

Editor: adjust grid layout for filters#11885
KhushalSainS wants to merge 2 commits into
WordPress:trunkfrom
KhushalSainS:fix/media-filter-alignment

Conversation

@KhushalSainS
Copy link
Copy Markdown

What?

Fixes the alignment of the "Filter by date" dropdown in the Media Library modal when the "Filter by type" dropdown is hidden.

Why?

When a media frame is opened with the library restricted to a single MIME type, for example:

wp.media({ library: { type: 'image' } }).open();

the "Filter by type" dropdown is hidden as expected. However, the date filter was still assigned to the second column of the toolbar grid in src/wp-includes/css/media-views.css:

label[for="media-attachment-date-filters"] {
	grid-area: 1 / 2 / 2 / 3;
}

select#media-attachment-date-filters {
	grid-area: 2 / 2 / 3 / 3;
}

As a result, the date filter appeared offset to the right, leaving an empty space where the type filter would normally appear.

How?

Updates the media toolbar grid positioning so the date filter uses the first column by default.

When the type filter is present, sibling selectors move the date filter back to the second column. This preserves the existing two-filter layout while fixing single-MIME-type media frames where the type filter is hidden.

Screenshots

Before After
image image

Testing Instructions

  1. Go to /wp-admin/post-new.php.

  2. Open the browser DevTools console.

  3. Run:

    wp.media({ library: { type: 'image' } }).open();
  4. Switch to the Media Library tab.

  5. Confirm that the "Filter by date" dropdown is aligned flush-left when the type filter is hidden.

  6. Open a normal media frame where both filters are visible.

  7. Confirm that "Filter by type" and "Filter by date" still appear side by side.

Trac ticket: https://core.trac.wordpress.org/ticket/65276

Use of AI Tools

AI assistance: Yes
Tool(s): Codex, ChatGPT
Model(s): GPT-5.5
Used for: Testing guidance, CSS fix suggestion. Final changes were reviewed and edited by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Refactor the grid layout for media attachment filters to improve
alignment and responsiveness. This change ensures that the labels
and select elements are properly positioned within the media frame.
@github-actions
Copy link
Copy Markdown

Hi @KhushalSainS! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @KhushalSainS.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props yogeshbhutkar.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@yogeshbhutkar
Copy link
Copy Markdown

Thanks for the PR. One additional observation: the filter isn’t aligned with the search box in this case. This appears to be an existing issue in Trunk as well. I’ve attached a screenshot for reference.

Screenshot 2026-05-20 at 9 35 33 AM

@KhushalSainS
Copy link
Copy Markdown
Author

Hi @yogeshbhutkar,

Thank you for pointing this out. I’ve updated the patch to address the alignment issue shown in the screenshot.

The fix is scoped specifically to media frames where the type filter is hidden and only the date filter is displayed, so the default toolbar layout with both filters remains unaffected.

image

@KhushalSainS KhushalSainS changed the title fix: adjust grid layout for filters Editor: adjust grid layout for filters May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants