Skip to content

Administration: Fix black flash on Connectors screen before hydration. #11892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
itzmekhokan wants to merge 1 commit into from
+35 −1
Closed

Administration: Fix black flash on Connectors screen before hydration. #11892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wp-includes/build/pages/options-connectors/page-wp-admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ function wp_options_connectors_wp_admin_render_page() {

/* Background colors */
#wpwrap {
background: var(--wpds-color-fg-content-neutral, #1e1e1e);
background: var(--wpds-color-bg-surface-neutral-weak, #f0f0f0);
overflow-y: auto;
}
body {
Expand Down
34 changes: 34 additions & 0 deletions tests/phpunit/tests/connectors/wpOptionsConnectorsWpAdminRenderPage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
<?php
/**
* Tests for the Connectors wp-admin page render output.
*
* @group connectors
*/
class Tests_Connectors_WpOptionsConnectorsWpAdminRenderPage extends WP_UnitTestCase {

/**
* Critical styles should use a background token for #wpwrap, not a foreground color.
*
* @ticket 65247
*/
public function test_render_page_critical_styles_use_background_token_for_wpwrap() {
if ( ! function_exists( 'wp_options_connectors_wp_admin_render_page' ) ) {
$this->markTestSkipped( 'Connectors build files are not available.' );
}

ob_start();
wp_options_connectors_wp_admin_render_page();
$output = ob_get_clean();

$this->assertStringContainsString(
'background: var(--wpds-color-bg-surface-neutral-weak, #f0f0f0)',
$output,
'#wpwrap should use the same background token as .boot-layout before hydration.'
);
$this->assertStringNotContainsString(
'background: var(--wpds-color-fg-content-neutral, #1e1e1e)',
$output,
'#wpwrap must not use a foreground color token as its background fallback.'
);
}
}
Loading