-
Notifications
You must be signed in to change notification settings - Fork 330
Update to specification from 40d6286fbe29fb083d416b77e84122df8d70ae9d #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update to specification from 40d6286fbe29fb083d416b77e84122df8d70ae9d #621
Conversation
Summary of ChangesHello @a2a-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refines the A2A protocol specification by updating existing message structures, introducing new capabilities, and enhancing API design. The changes focus on improving clarity, adding multi-tenancy support, modernizing authentication flows, and expanding agent card details, ensuring a more robust and flexible communication framework. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the project to a new version of the A2A specification. A critical issue has been identified in src/a2a/types.py where Pydantic models are out of sync with the new protobuf definitions, indicating incomplete regeneration. This inconsistency, along with unchanged crucial manually-written files, will likely lead to runtime errors. The primary focus should be to ensure all parts of the codebase are consistent with the new specification.
| @@ -1,5 +1,5 @@ | |||
| # generated by datamodel-codegen: | |||
| # filename: https://raw.githubusercontent.com/a2aproject/A2A/refs/heads/main/specification/json/a2a.json | |||
| # filename: https://raw.githubusercontent.com/a2aproject/A2A/refs/tags/v0.3.0/specification/json/a2a.json | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the source URL in the header comment has been updated to point to the v0.3.0 specification, the Pydantic models in this file do not seem to have been correctly regenerated. They appear to be out of sync with the new protobuf definitions, which will cause runtime failures.
For example, the AgentCard model in this file still contains fields like protocol_version, url, preferred_transport, additional_interfaces, and supports_authenticated_extended_card. However, the corresponding AgentCard message in a2a_pb2.py has replaced these with fields like protocol_versions and supported_interfaces.
This file needs to be regenerated from the correct v0.3.0 JSON schema to ensure consistency with the rest of the updated specification.
Commit: a2aproject/A2A@40d6286