remove ABSL_HAVE_PTHREAD_CPU_NUMBER_NP#2067
Open
h-vetinari wants to merge 1 commit into
Open
Conversation
derekmauro
requested changes
Jun 1, 2026
| // Checks whether pthread_cpu_number_np is available. | ||
| #ifdef ABSL_HAVE_PTHREAD_CPU_NUMBER_NP | ||
| #error ABSL_HAVE_PTHREAD_CPU_NUMBER_NP cannot be directly set | ||
| #elif defined(__APPLE__) && defined(__has_include) && \ |
Member
There was a problem hiding this comment.
Don't we still need the __APPLE__ test?
Contributor
Author
There was a problem hiding this comment.
Depends a bit on the pthread setup. I can restore it, but then ABSL_HAVE_PTHREAD_CPU_NUMBER_NP won't be removable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conditions are always satisfied based on the macOS lower bound that has long moved past the versions being considered here.